Bug 112169

Summary: [GTK] Enforce the C++11 standard when compiling WebKit2
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: a.renevier, cgarcia, gustavo, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2013-03-12 11:07:05 PDT
[GTK] Enforce the C++11 standard when compiling WebKit2
Attachments
Patch (5.56 KB, patch)
2013-03-12 11:15 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-03-12 11:15:35 PDT
Created attachment 192772 [details] Patch
WebKit Review Bot
Comment 2 2013-03-12 11:20:48 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gustavo Noronha (kov)
Comment 3 2013-03-12 12:36:15 PDT
Comment on attachment 192772 [details] Patch What does this gain us? Is the mac wk2 already built like this?
Zan Dobersek
Comment 4 2013-03-12 12:57:49 PDT
Yes, mac-wk2 already builds WebKit2 in such way, though they are using libc++ as the standard library and enforce the gnu++0x standard. I don't think enforcing c++11 instead of gnu++0x is problematic, at least not at the moment. I also plan to propose this patch for merging into webkit-2.0 for reasons I've detailed here: https://bugs.webkit.org/show_bug.cgi?id=109932#c15
Gustavo Noronha (kov)
Comment 5 2013-03-15 14:38:51 PDT
Comment on attachment 192772 [details] Patch OK, then =)
Zan Dobersek
Comment 6 2013-03-15 15:13:46 PDT
\o/ Thanks!
Zan Dobersek
Comment 7 2013-03-15 15:15:03 PDT
Comment on attachment 192772 [details] Patch Clearing flags on attachment: 192772 Committed r145951: <http://trac.webkit.org/changeset/145951>
Zan Dobersek
Comment 8 2013-03-15 15:15:08 PDT
All reviewed patches have been landed. Closing bug.
Zan Dobersek
Comment 9 2013-03-18 01:01:50 PDT
*** Bug 112034 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.