Summary: | [BlackBerry] SimpleFontData: remove duplicate code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 111729 | ||||||
Attachments: |
|
Description
Alberto Garcia
2013-03-12 07:15:22 PDT
Created attachment 192731 [details]
Patch
Comment on attachment 192731 [details]
Patch
These methods now return a PassRefPtr, don't you need to adapt the callers too? or this are only called in cross platform code?
(In reply to comment #2) > These methods now return a PassRefPtr, don't you need to adapt the > callers too? or this are only called in cross platform code? They're only called from SimpleFontData::variantFontData(), which is in Source/WebCore/platform/graphics/SimpleFontData.h Comment on attachment 192731 [details] Patch Clearing flags on attachment: 192731 Committed r145706: <http://trac.webkit.org/changeset/145706> All reviewed patches have been landed. Closing bug. |