Bug 112147

Summary: [Qt] Port TestRunner::findString to shared interface
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: jturcotte
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 112144    
Bug Blocks: 109677    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch jturcotte: review+

Simon Hausmann
Reported 2013-03-12 06:48:16 PDT
[Qt] Port TestRunner::findString to shared interface
Attachments
Patch (18.50 KB, patch)
2013-03-12 06:50 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (13.92 KB, patch)
2013-03-12 06:51 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (18.50 KB, patch)
2013-03-12 08:08 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (13.92 KB, patch)
2013-03-13 05:53 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (22.84 KB, patch)
2013-03-13 07:06 PDT, Simon Hausmann 		jturcotte: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2013-03-12 06:50:07 PDT
Created attachment 192727 [details] Patch
Simon Hausmann
Comment 2 2013-03-12 06:51:28 PDT
Created attachment 192728 [details] Patch
Simon Hausmann
Comment 3 2013-03-12 08:08:02 PDT
Created attachment 192738 [details] Patch
Benjamin Poulain
Comment 4 2013-03-13 00:37:24 PDT
Comment on attachment 192738 [details] Patch Wrong patch :(
Simon Hausmann
Comment 5 2013-03-13 05:53:31 PDT
Created attachment 192907 [details] Patch
Jocelyn Turcotte
Comment 6 2013-03-13 06:23:00 PDT
Comment on attachment 192907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192907&action=review > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:388 > +static DumpRenderTree *s_instance; The compiler should do it but it might be worth explicitely initializing it to 0. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:748 > +bool TestRunner::findString(JSContextRef context, JSStringRef string, JSObjectRef optionsArray) EFL, GTK, chromium and BlackBerry all seem to do the FindOptions matching in TestRunner instead of DumpRenderTreeSupport. It might be worth doing the same while we're there. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:750 > + DumpRenderTree* drt = DumpRenderTree::instance(); It seems like this could be moved right before or into the final return. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:766 > + Superfluous
Simon Hausmann
Comment 7 2013-03-13 07:01:57 PDT
Comment on attachment 192907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192907&action=review >> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:388 >> +static DumpRenderTree *s_instance; > > The compiler should do it but it might be worth explicitely initializing it to 0. Done. >> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:748 >> +bool TestRunner::findString(JSContextRef context, JSStringRef string, JSObjectRef optionsArray) > > EFL, GTK, chromium and BlackBerry all seem to do the FindOptions matching in TestRunner instead of DumpRenderTreeSupport. > It might be worth doing the same while we're there. Okay. >> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:750 >> + DumpRenderTree* drt = DumpRenderTree::instance(); > > It seems like this could be moved right before or into the final return. Good idea! done. >> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:766 >> + > > Superfluous Oops :)
Simon Hausmann
Comment 8 2013-03-13 07:06:21 PDT
Created attachment 192917 [details] Patch
Jocelyn Turcotte
Comment 9 2013-03-13 08:23:04 PDT
Comment on attachment 192917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192917&action=review LGTM after all :) > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:782 > + This can be removed, I didn't see it earlier
Simon Hausmann
Comment 10 2013-03-13 08:26:48 PDT
Committed r145719: <http://trac.webkit.org/changeset/145719>
Note You need to log in before you can comment on or make changes to this bug.