Bug 112137

Summary: Web Inspector: Fix JSDocs in TimelinePanel.js
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Eugene Klyuchnikov
Reported 2013-03-12 05:24:04 PDT
Source/WebCore/inspector/front-end/TimelinePanel.js:355: WARNING - actual parameter 1 of WebInspector.createFileSelectorElement does not match formal parameter found : function (string): undefined required: function (File): ? this._fileSelectorElement = WebInspector.createFileSelectorElement(this._loadFromFile.bind(this)); ^ Source/WebCore/inspector/front-end/TimelinePanel.js:384: WARNING - actual parameter 1 of WebInspector.TimelineModel.prototype.loadFromFile does not match formal parameter found : string required: Blob this._model.loadFromFile(fileName, progressIndicator); ^
Attachments
Patch (1.52 KB, patch)
2013-03-12 05:26 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-12 05:26:30 PDT
Created attachment 192716 [details] Patch
WebKit Review Bot
Comment 2 2013-03-12 05:47:44 PDT
Comment on attachment 192716 [details] Patch Clearing flags on attachment: 192716 Committed r145537: <http://trac.webkit.org/changeset/145537>
WebKit Review Bot
Comment 3 2013-03-12 05:47:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.