Bug 112136

Summary: [V8] Move the GetRawTemplate and HasInstance logic from generated bindings to V8PerIsolateData
Product: WebKit Reporter: Marja Hölttä <marja>
Component: New BugsAssignee: Marja Hölttä <marja>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dcarney, dgrogan, eric.carlson, feature-media-reviews, haraken, japhet, jer.noble, jsbell, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111724    
Attachments:
Description Flags
Patch none

Description Marja Hölttä 2013-03-12 05:16:12 PDT
When templates for main world and non-main worlds will be separated, HasInstance logic will be a bit ugly: We cannot determine the world type on the fly, because during GC there is no entered context, and HasInstance is called during GC. So we need to check against templates from all the worlds. It's cleaner if that logic is in V8PerIsolateData.
Comment 1 Marja Hölttä 2013-03-12 05:25:29 PDT
Created attachment 192715 [details]
Patch
Comment 2 Kentaro Hara 2013-03-12 05:31:28 PDT
Comment on attachment 192715 [details]
Patch

It's anyway a good idea to factor out duplicated logic from auto-generated code to V8Binding.cpp.
Comment 3 WebKit Review Bot 2013-03-12 06:04:20 PDT
Comment on attachment 192715 [details]
Patch

Clearing flags on attachment: 192715

Committed r145538: <http://trac.webkit.org/changeset/145538>
Comment 4 WebKit Review Bot 2013-03-12 06:04:25 PDT
All reviewed patches have been landed.  Closing bug.