Bug 112135

Summary: [BlackBerry] FontPlatformData: remove TextOrientation parameter
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
none
Patch none

Alberto Garcia
Reported 2013-03-12 04:59:52 PDT
This doesn't exist since r136520 (see bug 103971).
Attachments
Patch (6.13 KB, patch)
2013-03-12 05:01 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Patch (1.26 KB, patch)
2013-03-15 02:42 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-03-12 05:01:25 PDT
Created attachment 192712 [details] Patch
Rob Buis
Comment 2 2013-03-12 05:30:18 PDT
Comment on attachment 192712 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2013-03-13 02:08:26 PDT
Comment on attachment 192712 [details] Patch Clearing flags on attachment: 192712 Committed r145687: <http://trac.webkit.org/changeset/145687>
WebKit Review Bot
Comment 4 2013-03-13 02:08:37 PDT
All reviewed patches have been landed. Closing bug.
Alberto Garcia
Comment 5 2013-03-15 02:41:49 PDT
The #include "TextOrientation.h" line has to be removed as well, that file no longer exists.
Alberto Garcia
Comment 6 2013-03-15 02:42:21 PDT
Created attachment 193264 [details] Patch
Rob Buis
Comment 7 2013-03-15 05:58:22 PDT
Comment on attachment 193264 [details] Patch Ok.
WebKit Review Bot
Comment 8 2013-03-15 06:52:48 PDT
Comment on attachment 193264 [details] Patch Clearing flags on attachment: 193264 Committed r145902: <http://trac.webkit.org/changeset/145902>
WebKit Review Bot
Comment 9 2013-03-15 06:52:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.