Bug 112135 - [BlackBerry] FontPlatformData: remove TextOrientation parameter
Summary: [BlackBerry] FontPlatformData: remove TextOrientation parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency treegraph
 
Reported: 2013-03-12 04:59 PDT by Alberto Garcia
Modified: 2013-03-15 06:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.13 KB, patch)
2013-03-12 05:01 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff
Patch (1.26 KB, patch)
2013-03-15 02:42 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-12 04:59:52 PDT
This doesn't exist since r136520 (see bug 103971).
Comment 1 Alberto Garcia 2013-03-12 05:01:25 PDT
Created attachment 192712 [details]
Patch
Comment 2 Rob Buis 2013-03-12 05:30:18 PDT
Comment on attachment 192712 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-03-13 02:08:26 PDT
Comment on attachment 192712 [details]
Patch

Clearing flags on attachment: 192712

Committed r145687: <http://trac.webkit.org/changeset/145687>
Comment 4 WebKit Review Bot 2013-03-13 02:08:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alberto Garcia 2013-03-15 02:41:49 PDT
The #include "TextOrientation.h" line has to be removed as well,
that file no longer exists.
Comment 6 Alberto Garcia 2013-03-15 02:42:21 PDT
Created attachment 193264 [details]
Patch
Comment 7 Rob Buis 2013-03-15 05:58:22 PDT
Comment on attachment 193264 [details]
Patch

Ok.
Comment 8 WebKit Review Bot 2013-03-15 06:52:48 PDT
Comment on attachment 193264 [details]
Patch

Clearing flags on attachment: 193264

Committed r145902: <http://trac.webkit.org/changeset/145902>
Comment 9 WebKit Review Bot 2013-03-15 06:52:52 PDT
All reviewed patches have been landed.  Closing bug.