Bug 112131

Summary: [BlackBerry] Fix visible_units.h includes
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
cgarcia: review-, cgarcia: commit-queue-
Patch none

Description Alberto Garcia 2013-03-12 04:07:39 PDT 
This file was renamed to VisibleUnits.h in r144911

http://trac.webkit.org/changeset/144911
Comment 1 Alberto Garcia 2013-03-12 04:10:18 PDT 
Created attachment 192706 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-12 04:17:04 PDT 
Attachment 192706 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp']" exit_code: 1
Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:68:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2013-03-12 04:25:09 PDT 
Comment on attachment 192706 [details]
Patch

Please, fix the style issues. Thanks!
Comment 4 Alberto Garcia 2013-03-12 04:37:06 PDT 
Created attachment 192709 [details]
Patch
Comment 5 Carlos Garcia Campos 2013-03-12 05:04:01 PDT 
Comment on attachment 192709 [details]
Patch

Thanks
Comment 6 WebKit Review Bot 2013-03-12 05:14:09 PDT 
Comment on attachment 192709 [details]
Patch

Clearing flags on attachment: 192709

Committed r145529: <http://trac.webkit.org/changeset/145529>
Comment 7 WebKit Review Bot 2013-03-12 05:14:13 PDT 
All reviewed patches have been landed.  Closing bug.