Bug 112131 - [BlackBerry] Fix visible_units.h includes
Summary: [BlackBerry] Fix visible_units.h includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-03-12 04:07 PDT by Alberto Garcia
Modified: 2013-03-12 05:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.69 KB, patch)
2013-03-12 04:10 PDT, Alberto Garcia 		cgarcia: review-
cgarcia: commit-queue-
Details | Formatted Diff | Diff
Patch (2.98 KB, patch)
2013-03-12 04:37 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-12 04:07:39 PDT 
This file was renamed to VisibleUnits.h in r144911

http://trac.webkit.org/changeset/144911
Comment 1 Alberto Garcia 2013-03-12 04:10:18 PDT 
Created attachment 192706 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-12 04:17:04 PDT 
Attachment 192706 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp']" exit_code: 1
Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:68:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2013-03-12 04:25:09 PDT 
Comment on attachment 192706 [details]
Patch

Please, fix the style issues. Thanks!
Comment 4 Alberto Garcia 2013-03-12 04:37:06 PDT 
Created attachment 192709 [details]
Patch
Comment 5 Carlos Garcia Campos 2013-03-12 05:04:01 PDT 
Comment on attachment 192709 [details]
Patch

Thanks
Comment 6 WebKit Review Bot 2013-03-12 05:14:09 PDT 
Comment on attachment 192709 [details]
Patch

Clearing flags on attachment: 192709

Committed r145529: <http://trac.webkit.org/changeset/145529>
Comment 7 WebKit Review Bot 2013-03-12 05:14:13 PDT 
All reviewed patches have been landed.  Closing bug.