Bug 112129

Summary: [Chromium] Rename android_build_type to android_webview_build in .gyp files
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Tools / TestsAssignee: Mikhail Naganov <mnaganov>
Severity: Normal CC: abarth, benm, dglazkov, peter, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Description Flags
Patch none

Description Mikhail Naganov 2013-03-12 03:49:38 PDT
Following Chromium http://src.chromium.org/viewvc/chrome?view=rev&revision=187556 this is being renamed to better explain what it does.
Comment 1 Mikhail Naganov 2013-03-12 03:53:24 PDT
Created attachment 192702 [details]

Adam, please take a look!
Comment 2 Ben Murdoch 2013-03-12 04:02:55 PDT
lgtm thanks Mikhail!
Comment 3 Peter Beverloo (cr-android ews) 2013-03-12 04:16:53 PDT
Comment on attachment 192702 [details]

Attachment 192702 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17008708
Comment 4 Peter Beverloo 2013-03-12 04:21:51 PDT
Please be sure that WebKit rolls Chromium to or beyond r187556 before landing this patch, to avoid breaking the bots.  All four changes LGTM.
Comment 5 Mikhail Naganov 2013-03-12 09:24:43 PDT
Yes, sure. We are not in a rush.
Comment 6 Adam Barth 2013-03-12 11:37:02 PDT
Comment on attachment 192702 [details]

Comment 7 WebKit Review Bot 2013-03-13 07:15:28 PDT
Comment on attachment 192702 [details]

Clearing flags on attachment: 192702

Committed r145714: <http://trac.webkit.org/changeset/145714>
Comment 8 WebKit Review Bot 2013-03-13 07:15:32 PDT
All reviewed patches have been landed.  Closing bug.