Bug 112129

Summary: [Chromium] Rename android_build_type to android_webview_build in .gyp files
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Tools / TestsAssignee: Mikhail Naganov <mnaganov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benm, dglazkov, peter, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch none

Mikhail Naganov
Reported 2013-03-12 03:49:38 PDT
Following Chromium http://src.chromium.org/viewvc/chrome?view=rev&revision=187556 this is being renamed to better explain what it does.
Attachments
Patch (3.55 KB, patch)
2013-03-12 03:53 PDT, Mikhail Naganov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2013-03-12 03:53:24 PDT
Created attachment 192702 [details] Patch Adam, please take a look!
Ben Murdoch
Comment 2 2013-03-12 04:02:55 PDT
lgtm thanks Mikhail!
Peter Beverloo (cr-android ews)
Comment 3 2013-03-12 04:16:53 PDT
Comment on attachment 192702 [details] Patch Attachment 192702 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17008708
Peter Beverloo
Comment 4 2013-03-12 04:21:51 PDT
Please be sure that WebKit rolls Chromium to or beyond r187556 before landing this patch, to avoid breaking the bots. All four changes LGTM.
Mikhail Naganov
Comment 5 2013-03-12 09:24:43 PDT
Yes, sure. We are not in a rush.
Adam Barth
Comment 6 2013-03-12 11:37:02 PDT
Comment on attachment 192702 [details] Patch rs=me
WebKit Review Bot
Comment 7 2013-03-13 07:15:28 PDT
Comment on attachment 192702 [details] Patch Clearing flags on attachment: 192702 Committed r145714: <http://trac.webkit.org/changeset/145714>
WebKit Review Bot
Comment 8 2013-03-13 07:15:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.