Bug 112129 - [Chromium] Rename android_build_type to android_webview_build in .gyp files
Summary: [Chromium] Rename android_build_type to android_webview_build in .gyp files
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Mikhail Naganov
Depends on:
Reported: 2013-03-12 03:49 PDT by Mikhail Naganov
Modified: 2013-03-13 07:15 PDT (History)
6 users (show)

See Also:

Patch (3.55 KB, patch)
2013-03-12 03:53 PDT, Mikhail Naganov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2013-03-12 03:49:38 PDT
Following Chromium http://src.chromium.org/viewvc/chrome?view=rev&revision=187556 this is being renamed to better explain what it does.
Comment 1 Mikhail Naganov 2013-03-12 03:53:24 PDT
Created attachment 192702 [details]

Adam, please take a look!
Comment 2 Ben Murdoch 2013-03-12 04:02:55 PDT
lgtm thanks Mikhail!
Comment 3 Peter Beverloo (cr-android ews) 2013-03-12 04:16:53 PDT
Comment on attachment 192702 [details]

Attachment 192702 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17008708
Comment 4 Peter Beverloo 2013-03-12 04:21:51 PDT
Please be sure that WebKit rolls Chromium to or beyond r187556 before landing this patch, to avoid breaking the bots.  All four changes LGTM.
Comment 5 Mikhail Naganov 2013-03-12 09:24:43 PDT
Yes, sure. We are not in a rush.
Comment 6 Adam Barth 2013-03-12 11:37:02 PDT
Comment on attachment 192702 [details]

Comment 7 WebKit Review Bot 2013-03-13 07:15:28 PDT
Comment on attachment 192702 [details]

Clearing flags on attachment: 192702

Committed r145714: <http://trac.webkit.org/changeset/145714>
Comment 8 WebKit Review Bot 2013-03-13 07:15:32 PDT
All reviewed patches have been landed.  Closing bug.