Bug 112120

Summary: [Chromium] Remove WEBKIT_USING_V8 from the WebKit API
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, jamesr, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2013-03-12 02:26:06 PDT
[Chromium] Remove WEBKIT_USING_V8 from the WebKit API
Attachments
Patch (10.09 KB, patch)
2013-03-12 02:29 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (16.38 KB, patch)
2013-03-12 14:06 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-03-12 02:29:38 PDT
Created attachment 192680 [details] Patch
WebKit Review Bot
Comment 2 2013-03-12 02:31:56 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2013-03-12 03:01:03 PDT
Comment on attachment 192680 [details] Patch Attachment 192680 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17060618
Adam Barth
Comment 4 2013-03-12 03:10:45 PDT
Comment on attachment 192680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192680&action=review > Source/WebKit/chromium/public/WebFrame.h:-53 > -namespace v8 { > -class Context; > -class Function; > -class Object; > -class Value; > -template <class T> class Handle; > -template <class T> class Local; > -} We may need to keep this forward declaration. I'll study it in the morning.
Peter Beverloo (cr-android ews)
Comment 5 2013-03-12 03:22:56 PDT
Comment on attachment 192680 [details] Patch Attachment 192680 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17189054
WebKit Review Bot
Comment 6 2013-03-12 03:26:16 PDT
Comment on attachment 192680 [details] Patch Attachment 192680 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17147081
Eric Seidel (no email)
Comment 7 2013-03-12 04:13:23 PDT
Comment on attachment 192680 [details] Patch Wow this stuff is old.
Adam Barth
Comment 8 2013-03-12 14:06:25 PDT
Created attachment 192802 [details] Patch
Tony Chang
Comment 9 2013-03-12 14:08:50 PDT
Comment on attachment 192802 [details] Patch Should we also get rid of the #defines in WebCommon.h?
Adam Barth
Comment 10 2013-03-12 14:12:28 PDT
> Should we also get rid of the #defines in WebCommon.h? Yes, once https://codereview.chromium.org/12493009/ lands.
WebKit Review Bot
Comment 11 2013-03-12 14:56:30 PDT
Comment on attachment 192802 [details] Patch Clearing flags on attachment: 192802 Committed r145589: <http://trac.webkit.org/changeset/145589>
WebKit Review Bot
Comment 12 2013-03-12 14:56:34 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 13 2013-03-12 16:36:02 PDT
(In reply to comment #10) > > Should we also get rid of the #defines in WebCommon.h? > > Yes, once https://codereview.chromium.org/12493009/ lands. Done in bug 112203.
Note You need to log in before you can comment on or make changes to this bug.