Bug 112111

Summary: Web Inspector: Several inspector tests are flaky beacuse of beforeonload event handler.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Vsevolod Vlasov 2013-03-12 00:48:22 PDT 
An example of such test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fdebugger%2Fbreakpoint-manager.html

I think this is caused by calling window.addEventListener("beforeunload", onBeforeUnload); without removing such listener in inspector-protocol/page/javascriptDialogEvents.html

Patch to follow
Comment 1 Vsevolod Vlasov 2013-03-12 00:51:12 PDT 
Created attachment 192659 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-03-12 00:52:35 PDT 
Comment on attachment 192659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192659&action=review

> LayoutTests/ChangeLog:9
> +        Beforeunload message was updated so that it is possible to find it's source from it.

...its source...
Comment 3 WebKit Review Bot 2013-03-12 01:27:33 PDT 
Comment on attachment 192659 [details]
Patch

Clearing flags on attachment: 192659

Committed r145498: <http://trac.webkit.org/changeset/145498>
Comment 4 WebKit Review Bot 2013-03-12 01:27:37 PDT 
All reviewed patches have been landed.  Closing bug.