Bug 112096
| Summary: | [Meta] Track all usage of HitTestRequest::DisallowShadowContent in HitTests. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Hayato Ito <hayato> |
| Component: | UI Events | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | allan.jensen, cbiesinger, dglazkov, rniwa, tonikitoo, webcomponents-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 112073, 113171 | ||
| Bug Blocks: | 59805 | ||
Hayato Ito
This meta bug should track all usage of HitTestRequest::AllowShadowContent in EventHandler.
Some of them can be updated so that we can allow shadow content in HitTestResult.
- TouchEvent was fixed in http://trac.webkit.org/changeset/144877.
- Gesture Events should be also fixed, which is tracked in https://bugs.webkit.org/show_bug.cgi?id=112073
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dimitri Glazkov (Google)
We should fix this flag to be on by default. It's very rare that AllowShadowContent == false.
Hayato Ito
Yeah, that's our goal.
(In reply to comment #1)
> We should fix this flag to be on by default. It's very rare that AllowShadowContent == false.
Hayato Ito
HitTests are used from a lot of places in WebCore.
Turning the flag on the default requirers some braveness. I am pretty sure that existing Layout tests can not catch the regression.
My current plan is conservative. Use this flag for each cases step by step.
Tough, we need to figure out the usage in each places, which might take much time.
Hayato Ito
I feel that we must change the title of this bug after https://bugs.webkit.org/show_bug.cgi?id=113171 is landed, like: 'Track all usage of HitTestRequest::DisallowShadowContent' in WebKit.
(In reply to comment #3)
> HitTests are used from a lot of places in WebCore.
>
> Turning the flag on the default requirers some braveness. I am pretty sure that existing Layout tests can not catch the regression.
>
> My current plan is conservative. Use this flag for each cases step by step.
> Tough, we need to figure out the usage in each places, which might take much time.
Hayato Ito
https://bugs.webkit.org/show_bug.cgi?id=113171 was landed.
I've updated the title of this bug.
Antonio Gomes
Allan, I think we are good to close this bug now, right?
Ryosuke Niwa
HitTestRequest::DisallowShadowContent is not a thing anymore.
Radar WebKit Bug Importer
<rdar://problem/56003892>
Ryosuke Niwa
Oh, actually, this got renamed to DisallowUserAgentShadowContent. But I don't think we need this meta bug to track this.