Bug 112096

Summary:	[Meta] Track all usage of HitTestRequest::DisallowShadowContent in HitTests.
Product:	WebKit	Reporter:	Hayato Ito <hayato>
Component:	UI Events	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	allan.jensen, cbiesinger, dglazkov, rniwa, tonikitoo, webcomponents-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	112073, 113171
Bug Blocks:	59805

Description Hayato Ito 2013-03-11 19:34:34 PDT

This meta bug should track all usage of HitTestRequest::AllowShadowContent in EventHandler.

Some of them can be updated so that we can allow shadow content in HitTestResult.

- TouchEvent was fixed in  http://trac.webkit.org/changeset/144877.
- Gesture Events should be also fixed, which is tracked in https://bugs.webkit.org/show_bug.cgi?id=112073

Comment 1 Dimitri Glazkov (Google) 2013-03-11 19:44:11 PDT

We should fix this flag to be on by default. It's very rare that AllowShadowContent == false.

Comment 2 Hayato Ito 2013-03-11 20:41:30 PDT

Yeah, that's our goal.

(In reply to comment #1)
> We should fix this flag to be on by default. It's very rare that AllowShadowContent == false.

Comment 3 Hayato Ito 2013-03-17 23:54:44 PDT

HitTests are used from a lot of places in WebCore.

Turning the flag on the default requirers some braveness. I am pretty sure that existing Layout tests can not catch the regression.

My current plan is conservative. Use this flag for each cases step by step.
Tough, we need to figure out the usage in each places, which might take much time.

Comment 4 Hayato Ito 2013-03-25 01:07:29 PDT

I feel that we must change the title of this bug after https://bugs.webkit.org/show_bug.cgi?id=113171 is landed, like: 'Track all usage of HitTestRequest::DisallowShadowContent' in WebKit.

(In reply to comment #3)
> HitTests are used from a lot of places in WebCore.
> 
> Turning the flag on the default requirers some braveness. I am pretty sure that existing Layout tests can not catch the regression.
> 
> My current plan is conservative. Use this flag for each cases step by step.
> Tough, we need to figure out the usage in each places, which might take much time.

Comment 5 Hayato Ito 2013-03-27 00:18:11 PDT

https://bugs.webkit.org/show_bug.cgi?id=113171 was landed.
I've updated the title of this bug.

Comment 6 Antonio Gomes 2013-08-21 07:48:30 PDT

Allan, I think we are good to close this bug now, right?

Comment 7 Ryosuke Niwa 2019-10-04 22:36:30 PDT

HitTestRequest::DisallowShadowContent is not a thing anymore.

Comment 8 Radar WebKit Bug Importer 2019-10-04 22:37:17 PDT

<rdar://problem/56003892>

Comment 9 Ryosuke Niwa 2019-10-04 22:37:30 PDT

Oh, actually, this got renamed to DisallowUserAgentShadowContent. But I don't think we need this meta bug to track this.