Bug 112086
| Summary: | FontPlatformDataHarfBuzz::openTypeTable() endianness issue | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Behdad Esfahbod <behdad> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Trivial | CC: | d-r, fred.wang |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Behdad Esfahbod
This code:
PassRefPtr<SharedBuffer> FontPlatformData::openTypeTable(uint32_t table) const
{
RefPtr<SharedBuffer> buffer;
SkFontTableTag tag = reverseByteOrder(table);
It should only reverseByteOrder on little-endian systems, not unconditionally.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang (:fredw)
I can't find this code. Is it something that was part of Chrome and removed after the Blink fork?
Behdad Esfahbod
(In reply to comment #1)
> I can't find this code. Is it something that was part of Chrome and removed after the Blink fork?
Possible. The code still exists in Chrome under Skia.
Behdad Esfahbod
Filed here:
https://code.google.com/p/chromium/issues/detail?id=377562
This one should probably be closed.
Frédéric Wang (:fredw)
Thanks, Behdad.