Bug 112059

Summary: Make SegmentedVector Noncopyable
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, ggaren, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2013-03-11 13:21:06 PDT
Make SegmentedVector Noncopyable
Attachments
Patch (10.99 KB, patch)
2013-03-11 13:25 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-03-11 13:25:06 PDT
Created attachment 192538 [details] Patch
Geoffrey Garen
Comment 2 2013-03-11 13:37:01 PDT
Comment on attachment 192538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192538&action=review r=me > Source/JavaScriptCore/bytecompiler/LabelScope.h:79 > + struct LabelScopeRef { Let's make this a class. The idiomatic name for this in WebKit would be "LabelScopePtr".
Geoffrey Garen
Comment 3 2013-03-11 13:37:32 PDT
In future, I think we should just refactor LabelScope to be a true malloc'd, refcounted object, that knows how to notify the byte code generator when it is destroyed.
Oliver Hunt
Comment 4 2013-03-11 14:04:42 PDT
Committed r145401: <http://trac.webkit.org/changeset/145401>
Note You need to log in before you can comment on or make changes to this bug.