Bug 112059

Summary:

Make SegmentedVector Noncopyable

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, ggaren, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Description Oliver Hunt 2013-03-11 13:21:06 PDT

Make SegmentedVector Noncopyable

Comment 1 Oliver Hunt 2013-03-11 13:25:06 PDT

Created attachment 192538 [details]
Patch

Comment 2 Geoffrey Garen 2013-03-11 13:37:01 PDT

Comment on attachment 192538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192538&action=review

r=me

> Source/JavaScriptCore/bytecompiler/LabelScope.h:79
> +    struct LabelScopeRef {

Let's make this a class.

The idiomatic name for this in WebKit would be "LabelScopePtr".

Comment 3 Geoffrey Garen 2013-03-11 13:37:32 PDT

In future, I think we should just refactor LabelScope to be a true malloc'd, refcounted object, that knows how to notify the byte code generator when it is destroyed.

Comment 4 Oliver Hunt 2013-03-11 14:04:42 PDT

Committed r145401: <http://trac.webkit.org/changeset/145401>