Bug 112057

Summary: Factor HTMLTreeBuilderSimulator out of BackgroundHTMLParser
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, gyuyoung.kim, ojan.autocc, rakuco, rniwa, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2013-03-11 13:06:48 PDT
Factor HTMLTreeBuilderSimulator out of BackgroundHTMLParser
Attachments
Patch (25.76 KB, patch)
2013-03-11 13:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.21 KB, patch)
2013-03-11 13:28 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-03-11 13:11:19 PDT
Created attachment 192537 [details] Patch
WebKit Review Bot
Comment 2 2013-03-11 13:14:33 PDT
Attachment 192537 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/html/parser/BackgroundHTMLParser.cpp', u'Source/WebCore/html/parser/BackgroundHTMLParser.h', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.cpp', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h']" exit_code: 1 Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:42: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2013-03-11 13:17:54 PDT
Comment on attachment 192537 [details] Patch This is so much cleaner! This opens up a bunch of interesting possibilities for re-use of this code. :)
Adam Barth
Comment 4 2013-03-11 13:28:58 PDT
Created attachment 192541 [details] Patch for landing
WebKit Review Bot
Comment 5 2013-03-11 13:33:15 PDT
Attachment 192541 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/html/parser/BackgroundHTMLParser.cpp', u'Source/WebCore/html/parser/BackgroundHTMLParser.h', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.cpp', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h']" exit_code: 1 Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 6 2013-03-11 13:55:58 PDT
Comment on attachment 192541 [details] Patch for landing Clearing flags on attachment: 192541 Committed r145398: <http://trac.webkit.org/changeset/145398>
WebKit Review Bot
Comment 7 2013-03-11 13:56:03 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 8 2013-03-13 23:49:19 PDT
Mac build fix landed in http://trac.webkit.org/changeset/145781. (I forgot to mention it in the change log :()
Note You need to log in before you can comment on or make changes to this bug.