Bug 112041

Summary:

Web Inspector: [CodeMirror] highlight matching braces

Product:

WebKit

Reporter:

Andrey Lushnikov <lushnikov>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Lushnikov <lushnikov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
highlight matching braces	none
Patch	none
border bottom to decorate matching brackets	none

Andrey Lushnikov

Reported 2013-03-11 11:03:21 PDT

Highlight matching braces.

Attachments
Patch (9.89 KB, patch) 2013-03-11 11:05 PDT, Andrey Lushnikov	no flags	Details Formatted Diff Diff
highlight matching braces (1.80 KB, image/png) 2013-03-11 11:07 PDT, Andrey Lushnikov	no flags	Details
Patch (9.85 KB, patch) 2013-03-12 02:12 PDT, Andrey Lushnikov	no flags	Details Formatted Diff Diff
border bottom to decorate matching brackets (1.70 KB, image/png) 2013-03-12 02:12 PDT, Andrey Lushnikov	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andrey Lushnikov

Comment 1 2013-03-11 11:05:37 PDT

Created attachment 192511 [details] Patch

Andrey Lushnikov

Comment 2 2013-03-11 11:07:02 PDT

Created attachment 192512 [details] highlight matching braces

Vsevolod Vlasov

Comment 3 2013-03-12 01:27:21 PDT

Comment on attachment 192511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192511&action=review > Source/WebCore/inspector/front-end/cm/cmdevtools.css:36 > + text-decoration: underline; Can we use border-bottom to better control its position (this way we can make the border not touch the brace)?

Vsevolod Vlasov

Comment 4 2013-03-12 01:27:25 PDT

View in context: https://bugs.webkit.org/attachment.cgi?id=192511&action=review > Source/WebCore/inspector/front-end/cm/cmdevtools.css:36 > + text-decoration: underline; Can we use border-bottom to better control its position (this way we can make the border not touch the brace)?

Andrey Lushnikov

Comment 5 2013-03-12 02:12:15 PDT

Created attachment 192674 [details] Patch

Andrey Lushnikov

Comment 6 2013-03-12 02:12:35 PDT

Created attachment 192675 [details] border bottom to decorate matching brackets

WebKit Review Bot

Comment 7 2013-03-12 04:21:10 PDT

Comment on attachment 192674 [details] Patch Clearing flags on attachment: 192674 Committed r145520: <http://trac.webkit.org/changeset/145520>

WebKit Review Bot

Comment 8 2013-03-12 04:21:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.