Bug 111995

Summary: [wk2] Search With [your search provider here] should use NSPerformService in WebKit2/Mac
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, sam, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
stylebot happiness is good none

Tim Horton
Reported 2013-03-11 07:10:28 PDT
So that the context menu will open a tab in the browser instead of attempting to navigate the main frame, which is the wrong thing to do in some clients. Also, add support for the same feature to PDFPlugin, since it’s now free. <rdar://problem/12975669>
Attachments
patch (6.69 KB, patch)
2013-03-11 07:14 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
stylebot happiness is good (6.69 KB, patch)
2013-03-11 07:22 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-03-11 07:14:48 PDT
Created attachment 192460 [details] patch
WebKit Review Bot
Comment 2 2013-03-11 07:16:50 PDT
Attachment 192460 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm']" exit_code: 1 Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:82: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2013-03-11 07:22:31 PDT
Created attachment 192464 [details] stylebot happiness is good
WebKit Review Bot
Comment 4 2013-03-11 13:01:19 PDT
Comment on attachment 192464 [details] stylebot happiness is good Clearing flags on attachment: 192464 Committed r145390: <http://trac.webkit.org/changeset/145390>
WebKit Review Bot
Comment 5 2013-03-11 13:01:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.