Bug 111979

Summary: [Qt] Qml WebKit needs preferences to change security knobs
Product: WebKit Reporter: Maxim Ermilov <ermilov.maxim>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, allan.jensen, benjamin, cmarcelo, hausmann, jturcotte, kenneth, menard, michael.bruning, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Maxim Ermilov
Reported 2013-03-11 05:44:51 PDT
Qml WebKit needs preferences to change security knobs
Attachments
Patch (7.16 KB, patch)
2013-03-11 05:50 PDT, Maxim Ermilov 		no flags
DetailsFormatted DiffDiff
Patch (6.40 KB, patch)
2013-03-22 09:29 PDT, Maxim Ermilov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Maxim Ermilov
Comment 1 2013-03-11 05:50:48 PDT
Created attachment 192450 [details] Patch
Michael Brüning
Comment 2 2013-03-20 08:17:42 PDT
Looks good to me.
Jocelyn Turcotte
Comment 3 2013-03-20 08:26:34 PDT
LGTM This needs a WebKit2 Owner approval before this can go on. CCing Benjamin hoping he's not too busy :)
Jocelyn Turcotte
Comment 4 2013-03-20 08:26:59 PDT
CCing Benjamin for real this time.
Benjamin Poulain
Comment 5 2013-03-20 14:17:43 PDT
Comment on attachment 192450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192450&action=review Why do you need to expose WebSecurityEnabled? I am not too worried about the two others but a word of explanation for those would be nice. > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:594 > + d->setAttribute(QWebPreferencesPrivate::UniversalAccessFromFileURLsAllowed, enable); > + emit universalAccessFromFileURLsAllowedChanged(); You don't check the original value before emitting the signal? > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:605 > + d->setAttribute(QWebPreferencesPrivate::FileAccessFromFileURLsAllowed, enable); > + emit fileAccessFromFileURLsAllowedChanged(); Ditto. > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:616 > + d->setAttribute(QWebPreferencesPrivate::WebSecurityEnabled, enable); > + emit webSecurityEnabledChanged(); Ditto.
Maxim Ermilov
Comment 6 2013-03-22 09:29:12 PDT
Created attachment 194568 [details] Patch
Maxim Ermilov
Comment 7 2013-03-22 09:32:18 PDT
> Why do you need to expose WebSecurityEnabled? I need 2 others, WebSecurityEnabled was added just in case of future needs. (expose only UniversalAccessFromFileURLsAllowed/FileAccessFromFileURLsAllowed in patch) > You don't check the original value before emitting the signal? fixed
Benjamin Poulain
Comment 8 2013-03-22 15:08:13 PDT
Comment on attachment 194568 [details] Patch Signed off by me for WebKit2.
Jocelyn Turcotte
Comment 9 2013-03-25 05:59:30 PDT
Comment on attachment 194568 [details] Patch (In reply to comment #8) > (From update of attachment 194568 [details]) > Signed off by me for WebKit2. r=me (with special thanks to Benjamin for covering my slopiness)
WebKit Review Bot
Comment 10 2013-03-25 06:56:40 PDT
Comment on attachment 194568 [details] Patch Clearing flags on attachment: 194568 Committed r146766: <http://trac.webkit.org/changeset/146766>
WebKit Review Bot
Comment 11 2013-03-25 06:56:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.