Bug 111978

Summary: Web Inspector: [CodeMirror] bug with LineWidgets
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, mkwst+watchlist, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Andrey Lushnikov
Reported 2013-03-11 05:44:13 PDT
When error bubble gets added to CodeMirror it's whole layout seems to be mislayouted as if nothing was added to its DOM.
Attachments
Patch (3.34 KB, patch)
2013-03-11 05:47 PDT, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (4.36 KB, patch)
2013-03-11 09:34 PDT, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-03-11 05:47:03 PDT
Created attachment 192449 [details] Patch
Pavel Feldman
Comment 2 2013-03-11 08:51:47 PDT
Comment on attachment 192449 [details] Patch You missed one return in the middle.
Andrey Lushnikov
Comment 3 2013-03-11 09:34:23 PDT
Created attachment 192485 [details] Patch
Andrey Lushnikov
Comment 4 2013-03-11 11:08:15 PDT
I slightly modified the order of operations - now it should look good.
WebKit Review Bot
Comment 5 2013-03-13 08:49:49 PDT
Comment on attachment 192485 [details] Patch Clearing flags on attachment: 192485 Committed r145723: <http://trac.webkit.org/changeset/145723>
WebKit Review Bot
Comment 6 2013-03-13 08:49:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.