Bug 111978 - Web Inspector: [CodeMirror] bug with LineWidgets
Summary: Web Inspector: [CodeMirror] bug with LineWidgets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 05:44 PDT by Andrey Lushnikov
Modified: 2013-03-13 08:49 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.34 KB, patch)
2013-03-11 05:47 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2013-03-11 09:34 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-11 05:44:13 PDT 
When error bubble gets added to CodeMirror it's whole layout seems to be mislayouted as if nothing was added to its DOM.
Comment 1 Andrey Lushnikov 2013-03-11 05:47:03 PDT 
Created attachment 192449 [details]
Patch
Comment 2 Pavel Feldman 2013-03-11 08:51:47 PDT 
Comment on attachment 192449 [details]
Patch

You missed one return in the middle.
Comment 3 Andrey Lushnikov 2013-03-11 09:34:23 PDT 
Created attachment 192485 [details]
Patch
Comment 4 Andrey Lushnikov 2013-03-11 11:08:15 PDT 
I slightly modified the order of operations - now it should look good.
Comment 5 WebKit Review Bot 2013-03-13 08:49:49 PDT 
Comment on attachment 192485 [details]
Patch

Clearing flags on attachment: 192485

Committed r145723: <http://trac.webkit.org/changeset/145723>
Comment 6 WebKit Review Bot 2013-03-13 08:49:53 PDT 
All reviewed patches have been landed.  Closing bug.