Bug 111972

Summary: [BlackBerry] SelectionHandler: bring back m_lastSelection attribute
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cgarcia, mifenton, rniwa, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch none

Description Alberto Garcia 2013-03-11 04:32:13 PDT 
This was removed in r144515 but is still needed by SelectionHandler::selectionPositionChanged()

http://trac.webkit.org/changeset/144515/trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h
Comment 1 Alberto Garcia 2013-03-11 04:33:26 PDT 
Created attachment 192438 [details]
Patch
Comment 2 Build Bot 2013-03-11 05:58:49 PDT 
Comment on attachment 192438 [details]
Patch

Attachment 192438 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17077829

New failing tests:
fast/css/sticky/sticky-both-sides.html
fast/css/sticky/inline-sticky.html
Comment 3 Rob Buis 2013-03-11 07:33:03 PDT 
Comment on attachment 192438 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2013-03-11 08:35:47 PDT 
Comment on attachment 192438 [details]
Patch

Clearing flags on attachment: 192438

Committed r145365: <http://trac.webkit.org/changeset/145365>
Comment 5 WebKit Review Bot 2013-03-11 08:35:51 PDT 
All reviewed patches have been landed.  Closing bug.