Bug 111965

Summary: Web Inspector: extract common parts of native profiles
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch apavlov: review+

Description Yury Semikhatsky 2013-03-11 02:28:17 PDT 
Most of the profile type logic can be shared between native heap graph profiles and profiles with aggregated statistics. Since we are going to add more details to the aggregated view it makes sense to unify the mechanisms first.
Comment 1 Yury Semikhatsky 2013-03-11 02:38:49 PDT 
Created attachment 192428 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-03-11 02:46:04 PDT 
Comment on attachment 192428 [details]
Patch

lgtm
Comment 3 Yury Semikhatsky 2013-03-11 05:08:40 PDT 
Created attachment 192443 [details]
Patch
Comment 4 Yury Semikhatsky 2013-03-11 05:18:35 PDT 
Created attachment 192445 [details]
Patch
Comment 5 Alexander Pavlov (apavlov) 2013-03-11 05:40:50 PDT 
Comment on attachment 192445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192445&action=review

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:446
> +        var metaInformation = /** @type{HeapSnapshotMetainfo} */(graphMetaInformation);

Whitespace in front of '(' (according to the code I've seen around)

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:585
> +        this.sidebarElement.subtitle = Number.bytesToString(/** @type{number} */(this._memoryBlock.size));

ditto
Comment 6 Yury Semikhatsky 2013-03-11 05:45:24 PDT 
Committed r145357: <http://trac.webkit.org/changeset/145357>