Bug 111962

Summary:

RenderSnapshottedPlugIn paints in PaintPhaseBlockBackground instead of PaintPhaseForeground

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Plug-ins

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	dino: review+

Description Tim Horton 2013-03-11 01:30:36 PDT

This doesn't make sense to me, and breaks with plugins that are display: block'd (http://www.earslap.com/projectslab/otomata).

Plugins normally (see RenderWidget::paint) paint in the foreground phase.

There might be a good reason things are as they are now, so I'd like Dino to review this.

<rdar://problem/13289335>

Comment 1 Tim Horton 2013-03-11 01:32:03 PDT

Created attachment 192424 [details]
patch

Comment 2 Dean Jackson 2013-03-11 01:43:27 PDT

Comment on attachment 192424 [details]
patch

Nope - you're right! This explains the disappearing snapshots :)

Comment 3 Tim Horton 2013-03-11 01:45:53 PDT

Excellent.

http://trac.webkit.org/changeset/145346