| Summary: | [CSS Grid Layout] Handle spanning grid items over specified grid tracks | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||||
| Component: | Layout and Rendering | Assignee: | Julien Chaffraix <jchaffraix> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, esprehn+autocc, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 103314 | ||||||||
| Attachments: |
|
||||||||
|
Description
Julien Chaffraix
2013-03-08 20:41:02 PST
Created attachment 192332 [details]
Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes.
Comment on attachment 192332 [details] Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes. View in context: https://bugs.webkit.org/attachment.cgi?id=192332&action=review > Source/WebCore/rendering/RenderGrid.cpp:750 > + // We don't support spanning with auto positions yet. Nit: Should this be a FIXME? Comment on attachment 192332 [details] Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes. View in context: https://bugs.webkit.org/attachment.cgi?id=192332&action=review >> Source/WebCore/rendering/RenderGrid.cpp:750 >> + // We don't support spanning with auto positions yet. > > Nit: Should this be a FIXME? Good point, there is also not a single bug I can't point to as it really depends how much of the <grid-line> grammar we support. Created attachment 192521 [details]
Patch for landing
Comment on attachment 192521 [details] Patch for landing Clearing flags on attachment: 192521 Committed r145378: <http://trac.webkit.org/changeset/145378> All reviewed patches have been landed. Closing bug. |