Bug 111879

Summary: Don't use bash constructs in Source/autotools/FindDependencies.m4
Product: WebKit Reporter: Landry Breuil <landry>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: berto, gustavo, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Other   
Attachments:
Description Flags
Use a="$a foo" to append instead of using a+=" foo" none

Landry Breuil
Reported 2013-03-08 11:28:21 PST
Created attachment 192255 [details] Use a="$a foo" to append instead of using a+=" foo" https://bugs.webkit.org/show_bug.cgi?id=109246 splitted stuff from configure.ac to Source/autotools. As it is now, it doesnt build on hosts where sh is not bash, because it uses a+="foo" constructs which are not valid in posix shells. $a+="bar" ksh: a+=bar: not found
Attachments
Use a="$a foo" to append instead of using a+=" foo" (1.46 KB, patch)
2013-03-08 11:28 PST, Landry Breuil 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2013-03-08 11:32:27 PST
Attachment 192255 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alberto Garcia
Comment 2 2013-10-09 14:59:40 PDT
lgtm
Zan Dobersek
Comment 3 2013-10-09 23:01:50 PDT
This was fixed under bug #117796. *** This bug has been marked as a duplicate of bug 117796 ***
Zan Dobersek
Comment 4 2013-10-09 23:02:59 PDT
Comment on attachment 192255 [details] Use a="$a foo" to append instead of using a+=" foo" Still, thanks for reporting.
Note You need to log in before you can comment on or make changes to this bug.