Bug 111863

Summary: [Stable][GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, buildbot, cgarcia, gustavo, mrobinson, rniwa, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Manuel Rego Casasnovas 2013-03-08 08:50:27 PST 
The warning is:
../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::unavailablePluginButtonClicked' [-Wmissing-field-initializers]
Comment 1 Manuel Rego Casasnovas 2013-03-08 08:52:08 PST 
(In reply to comment #0)
> The warning is:
> ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::unavailablePluginButtonClicked' [-Wmissing-field-initializers]

Sorry this one is in master not in the stable branch, the one in the stable branch is:

../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::pluginLoadPolicy' [-Wmissing-field-initializers]
Comment 2 Manuel Rego Casasnovas 2013-03-08 08:54:06 PST 
Created attachment 192233 [details]
Patch
Comment 3 WebKit Review Bot 2013-03-08 08:59:48 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Martin Robinson 2013-03-08 09:09:29 PST 
Comment on attachment 192233 [details]
Patch

Looks good to me.
Comment 5 Carlos Garcia Campos 2013-03-08 09:33:17 PST 
Committed in the stable branch http://trac.webkit.org/changeset/145234
Comment 6 Manuel Rego Casasnovas 2013-03-08 13:08:04 PST 
Adding WK2 owners to CC.
Comment 7 Benjamin Poulain 2013-03-08 13:59:40 PST 
Comment on attachment 192233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192233&action=review

Please fix the name before landing.

> Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211
> +        0, // pluginLoadPolicy

In my repository, this callback is named "unavailablePluginButtonClicked"
Comment 8 Build Bot 2013-03-09 01:26:58 PST 
Comment on attachment 192233 [details]
Patch

Attachment 192233 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17060461

New failing tests:
fast/css/sticky/inline-sticky.html
Comment 9 WebKit Review Bot 2013-03-09 01:52:58 PST 
Comment on attachment 192233 [details]
Patch

Clearing flags on attachment: 192233

Committed r145308: <http://trac.webkit.org/changeset/145308>
Comment 10 WebKit Review Bot 2013-03-09 01:53:02 PST 
All reviewed patches have been landed.  Closing bug.