Bug 111854

Summary: Making more sophisticated cache flush on ARM Linux platform
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, oliver, ossy, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
proposed patch
zherczeg: review-, zherczeg: commit-queue-
proposed patch 2 zherczeg: review+, zherczeg: commit-queue-

Gabor Rapcsanyi
Reported 2013-03-08 07:04:58 PST
Now the cache flush on ARM Linux is invalidate whole pages instead of just the required areas.
Attachments
proposed patch (5.78 KB, patch)
2013-03-08 08:08 PST, Gabor Rapcsanyi 		zherczeg: review-
zherczeg: commit-queue-
DetailsFormatted DiffDiff
proposed patch 2 (5.78 KB, patch)
2013-03-11 05:51 PDT, Gabor Rapcsanyi 		zherczeg: review+
zherczeg: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2013-03-08 08:08:19 PST
Created attachment 192231 [details] proposed patch With this solution we go through all the affected pages and invalidate just the required areas.
Zoltan Herczeg
Comment 2 2013-03-11 05:08:05 PDT
Comment on attachment 192231 [details] proposed patch Nice patch, but: View in context: https://bugs.webkit.org/attachment.cgi?id=192231&action=review > Source/JavaScriptCore/assembler/ARMAssembler.h:1060 > + for (current = firstPageEnd; current < end; current += pageSize()) I think this is incorrect. Are you sure it is not "current + pageSize() < end"?
Gabor Rapcsanyi
Comment 3 2013-03-11 05:51:18 PDT
Created attachment 192451 [details] proposed patch 2 I've fixed that condition in the for cycle.
Zoltan Herczeg
Comment 4 2013-03-12 02:21:30 PDT
Comment on attachment 192451 [details] proposed patch 2 r=me. View in context: https://bugs.webkit.org/attachment.cgi?id=192451&action=review > Source/JavaScriptCore/ChangeLog:9 > + The cache flush on ARM Linux is invalidate whole pages > + instead of just the required areas. Fix grammar please.
Gabor Rapcsanyi
Comment 5 2013-03-12 02:47:08 PDT
Thanks! Patch landed: http://trac.webkit.org/changeset/145505
Note You need to log in before you can comment on or make changes to this bug.