Bug 111848

Summary: [GTK] Add webkit_web_context_set_disk_cache_directory to WebKit2 GTK+ API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, danw, gns, gyuyoung.kim, mrobinson, rakuco, svillar, webkit.review.bot, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 111845    
Bug Blocks: 113036    
Attachments:
Description Flags
Patch andersca: review+

Description Carlos Garcia Campos 2013-03-08 05:30:21 PST 
ssia
Comment 1 Carlos Garcia Campos 2013-03-08 05:32:49 PST 
Created attachment 192205 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-08 05:38:23 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gustavo Noronha (kov) 2013-03-11 07:03:56 PDT 
Comment on attachment 192205 [details]
Patch

This API looks straightforward enough for me, looks good
Comment 4 Carlos Garcia Campos 2013-03-11 07:07:40 PDT 
(In reply to comment #3)
> (From update of attachment 192205 [details])
> This API looks straightforward enough for me, looks good

Thanks for the review, this is useless until bug #111845 is fixed, though.
Comment 5 Carlos Garcia Campos 2013-03-24 03:36:11 PDT 
Comment on attachment 192205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192205&action=review

> Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47
> +        GOwnPtr<char> filePath(g_build_filename(directoryPath, fileName, 0));

Auto-review reminder :-P This should be NULL instead of 0, since it's a sentinel.
Comment 6 Carlos Garcia Campos 2013-04-22 09:02:23 PDT 
Committed r148887: <http://trac.webkit.org/changeset/148887>