Summary: | Add Nils Barth and Koji Hara to committers.py as Contributor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nils Barth <nbarth> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dpranke, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Nils Barth
2013-03-07 18:37:23 PST
Created attachment 192125 [details]
Patch
Comment on attachment 192125 [details]
Patch
Historically we have each committer had themselves individually and then commit the file directly (not using the cq), so that we can be sure the access controls are working.
Can you please delete koji hara and have them submit their own change?
Created attachment 192127 [details]
Patch
(In reply to comment #2) > (From update of attachment 192125 [details]) > Historically we have each committer had themselves individually and then commit the file directly (not using the cq), so that we can be sure the access controls are working. I'm only adding myself as a Contributor (for autocomplete etc.), not a Committer, so I can't commit the file myself, so I'll need a cq? as well. (Once I'll submit a separate patch to move myself to Committer instead.) > Can you please delete koji hara and have them submit their own change? Done! Thanks for explaining! Comment on attachment 192127 [details]
Patch
thanks! as mentioned previously, please try to land this directly rather than using the CQ.
Comment on attachment 192127 [details]
Patch
The "don't use the commit-queue" concern is about adding Committers and Reviewers is my understanding.
Comment on attachment 192125 [details]
Patch
This patch would have been fine too.
Comment on attachment 192125 [details]
Patch
Dirk is correct in parrotting the party line. But the party line only applies to Committer/Reviewer changes is my understanding. Thank you all!
Comment on attachment 192127 [details]
Patch
We'll try and land the bigger one for now.
Comment on attachment 192125 [details] Patch Rejecting attachment 192125 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 192125, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-commit-queue.appspot.com/results/17066262 Comment on attachment 192125 [details] Patch Clearing flags on attachment: 192125 Committed r145176: <http://trac.webkit.org/changeset/145176> All reviewed patches have been landed. Closing bug. |