| Summary: | [chromium] Use SkMatrix44 instead of WebTransformationMatrix in animation APIs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, cc-bugs, dglazkov, enne, fishd, peter+ews, shawnsingh, tkent+wkapi, vollick, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2013-03-07 16:25:15 PST
Created attachment 192103 [details]
Patch
This depends on https://codereview.chromium.org/12629006/. Ian/Shawn - if you want to optimize the TransformationMatrix -> SkMatrix44 conversion it's now in its own file that can be easily hit in unit tests. Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 192103 [details] Patch Attachment 192103 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17081209 Comment on attachment 192103 [details] Patch Attachment 192103 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17087072 Comment on attachment 192103 [details] Patch Attachment 192103 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17066222 Comment on attachment 192103 [details]
Patch
R=me.
Comment on attachment 192103 [details]
Patch
DEPS is >= 186902
Comment on attachment 192103 [details] Patch Clearing flags on attachment: 192103 Committed r145442: <http://trac.webkit.org/changeset/145442> All reviewed patches have been landed. Closing bug. |