Bug 111791

Summary: [chromium] Use SkMatrix44 instead of WebTransformationMatrix in animation APIs
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, dglazkov, enne, fishd, peter+ews, shawnsingh, tkent+wkapi, vollick, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

James Robinson
Reported 2013-03-07 16:25:15 PST
[chromium] Use SkMatrix44 instead of WebTransformationMatrix in animation APIs
Attachments
Patch (26.43 KB, patch)
2013-03-07 16:30 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-03-07 16:30:32 PST
Created attachment 192103 [details] Patch
James Robinson
Comment 2 2013-03-07 16:31:49 PST
This depends on https://codereview.chromium.org/12629006/. Ian/Shawn - if you want to optimize the TransformationMatrix -> SkMatrix44 conversion it's now in its own file that can be easily hit in unit tests.
WebKit Review Bot
Comment 3 2013-03-07 16:38:08 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 4 2013-03-07 16:46:12 PST
Comment on attachment 192103 [details] Patch Attachment 192103 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17081209
Peter Beverloo (cr-android ews)
Comment 5 2013-03-07 17:04:56 PST
Comment on attachment 192103 [details] Patch Attachment 192103 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17087072
WebKit Review Bot
Comment 6 2013-03-07 18:12:55 PST
Comment on attachment 192103 [details] Patch Attachment 192103 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17066222
Adrienne Walker
Comment 7 2013-03-11 14:45:01 PDT
Comment on attachment 192103 [details] Patch R=me.
James Robinson
Comment 8 2013-03-11 15:11:45 PDT
Comment on attachment 192103 [details] Patch DEPS is >= 186902
WebKit Review Bot
Comment 9 2013-03-11 17:47:45 PDT
Comment on attachment 192103 [details] Patch Clearing flags on attachment: 192103 Committed r145442: <http://trac.webkit.org/changeset/145442>
WebKit Review Bot
Comment 10 2013-03-11 17:47:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.