Summary: | [chromium] Android apk targets should depend directly on Java library targets | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Hopman <cjhopman> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, peter, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Hopman
2013-03-07 09:56:22 PST
Created attachment 192031 [details]
Patch
Created attachment 192043 [details]
Patch
Comment on attachment 192043 [details]
Patch
Looks reasonable to me.
This looks good to me, thanks Chris. Did you verify that both targets still run? (In reply to comment #4) > This looks good to me, thanks Chris. Did you verify that both targets still run? Yeah, the targets still run. Comment on attachment 192043 [details]
Patch
Cool, thanks for confirming.
Comment on attachment 192043 [details] Patch Clearing flags on attachment: 192043 Committed r145355: <http://trac.webkit.org/changeset/145355> All reviewed patches have been landed. Closing bug. |