111746 – [chromium] Android apk targets should depend directly on Java library targets

Bug 111746 - [chromium] Android apk targets should depend directly on Java library targets

Summary: [chromium] Android apk targets should depend directly on Java library targets

Attachments
Patch (3.93 KB, patch) 2013-03-07 10:04 PST, Chris Hopman	no flags	Details \| Formatted Diff \| Diff
Patch (3.96 KB, patch) 2013-03-07 10:41 PST, Chris Hopman	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chris Hopman 2013-03-07 09:56:22 PST

Android apk targets should depend directly on Java library targets

Comment 1 Chris Hopman 2013-03-07 10:04:57 PST

Created attachment 192031 [details]
Patch

Comment 2 Chris Hopman 2013-03-07 10:41:14 PST

Created attachment 192043 [details]
Patch

Comment 3 Eric Seidel (no email) 2013-03-07 13:02:16 PST

Comment on attachment 192043 [details]
Patch

Looks reasonable to me.

Comment 4 Peter Beverloo 2013-03-08 05:30:49 PST

This looks good to me, thanks Chris.  Did you verify that both targets still run?

Comment 5 Chris Hopman 2013-03-08 14:30:30 PST

(In reply to comment #4)
> This looks good to me, thanks Chris.  Did you verify that both targets still run?

Yeah, the targets still run.

Comment 6 Peter Beverloo 2013-03-11 04:05:28 PDT

Comment on attachment 192043 [details]
Patch

Cool, thanks for confirming.

Comment 7 WebKit Review Bot 2013-03-11 04:14:00 PDT

Comment on attachment 192043 [details]
Patch

Clearing flags on attachment: 192043

Committed r145355: <http://trac.webkit.org/changeset/145355>

Comment 8 WebKit Review Bot 2013-03-11 04:14:03 PDT

All reviewed patches have been landed.  Closing bug.