RESOLVED FIXED 111746
[chromium] Android apk targets should depend directly on Java library targets 
https://bugs.webkit.org/show_bug.cgi?id=111746
Summary [chromium] Android apk targets should depend directly on Java library targets
Chris Hopman
Reported 2013-03-07 09:56:22 PST
Android apk targets should depend directly on Java library targets
Attachments
Patch (3.93 KB, patch)
2013-03-07 10:04 PST, Chris Hopman 		no flags
DetailsFormatted DiffDiff
Patch (3.96 KB, patch)
2013-03-07 10:41 PST, Chris Hopman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Hopman
Comment 1 2013-03-07 10:04:57 PST
Created attachment 192031 [details] Patch
Chris Hopman
Comment 2 2013-03-07 10:41:14 PST
Created attachment 192043 [details] Patch
Eric Seidel (no email)
Comment 3 2013-03-07 13:02:16 PST
Comment on attachment 192043 [details] Patch Looks reasonable to me.
Peter Beverloo
Comment 4 2013-03-08 05:30:49 PST
This looks good to me, thanks Chris. Did you verify that both targets still run?
Chris Hopman
Comment 5 2013-03-08 14:30:30 PST
(In reply to comment #4) > This looks good to me, thanks Chris. Did you verify that both targets still run? Yeah, the targets still run.
Peter Beverloo
Comment 6 2013-03-11 04:05:28 PDT
Comment on attachment 192043 [details] Patch Cool, thanks for confirming.
WebKit Review Bot
Comment 7 2013-03-11 04:14:00 PDT
Comment on attachment 192043 [details] Patch Clearing flags on attachment: 192043 Committed r145355: <http://trac.webkit.org/changeset/145355>
WebKit Review Bot
Comment 8 2013-03-11 04:14:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.