Bug 111733

Summary: [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
Product: WebKit Reporter: Mike Fenton <mifenton>
Component: WebKit BlackBerryAssignee: Mike Fenton <mifenton>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, gmak, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rwlbuis: review+
Patch with reviewers denoted.
none
Additional Patch.
none
Replacement patch.
none
Fix compilation error none

Mike Fenton
Reported 2013-03-07 08:17:14 PST
BlackBerry port uses button rendering and popups for input, text selection should not be allowed.
Attachments
Patch (2.69 KB, patch)
2013-03-07 08:27 PST, Mike Fenton 		rwlbuis: review+
DetailsFormatted DiffDiff
Patch with reviewers denoted. (2.72 KB, patch)
2013-03-07 11:31 PST, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Additional Patch. (2.72 KB, patch)
2013-03-12 10:45 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Replacement patch. (2.77 KB, patch)
2013-03-12 10:58 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Fix compilation error (1.76 KB, patch)
2013-03-14 04:33 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2013-03-07 08:27:30 PST
Created attachment 192004 [details] Patch
gmak
Comment 2 2013-03-07 10:52:35 PST
Internal Reviewer: Me r+. Looks good.
Rob Buis
Comment 3 2013-03-07 11:06:00 PST
Comment on attachment 192004 [details] Patch LGTM.
Mike Fenton
Comment 4 2013-03-07 11:31:56 PST
Created attachment 192055 [details] Patch with reviewers denoted.
WebKit Review Bot
Comment 5 2013-03-07 12:57:34 PST
Comment on attachment 192055 [details] Patch with reviewers denoted. Clearing flags on attachment: 192055 Committed r145121: <http://trac.webkit.org/changeset/145121>
WebKit Review Bot
Comment 6 2013-03-07 12:57:37 PST
All reviewed patches have been landed. Closing bug.
Mike Fenton
Comment 7 2013-03-12 10:45:31 PDT
Created attachment 192764 [details] Additional Patch.
Mike Fenton
Comment 8 2013-03-12 10:45:55 PDT
Re-opening for additional case.
gmak
Comment 9 2013-03-12 10:57:33 PDT
I prefer not to do nested if statements but the logic is sound whatever way you do it. r+ with style improved.
Mike Fenton
Comment 10 2013-03-12 10:58:10 PDT
Created attachment 192769 [details] Replacement patch.
Rob Buis
Comment 11 2013-03-12 11:03:09 PDT
Comment on attachment 192769 [details] Replacement patch. LGTM.
WebKit Review Bot
Comment 12 2013-03-12 11:40:46 PDT
Comment on attachment 192769 [details] Replacement patch. Clearing flags on attachment: 192769 Committed r145571: <http://trac.webkit.org/changeset/145571>
WebKit Review Bot
Comment 13 2013-03-12 11:40:50 PDT
All reviewed patches have been landed. Closing bug.
Alberto Garcia
Comment 14 2013-03-14 04:33:03 PDT
Created attachment 193105 [details] Fix compilation error + if (Node* focusedNode = frame->document()->focusedNode() + && (focusedNode->hasTagName(HTMLNames::selectTag) || (focusedNode->isElementNode() && DOMSupport::isPopupInputField(toElement(focusedNode))))) { + SelectionLog(Platform::LogLevelInfo, "SelectionHandler::selectionPositionChanged selection is on a popup control, skipping rendering."); + return; + } + } Uh, oh, there's one brace missing, this won't compile.
Rob Buis
Comment 15 2013-03-14 07:23:23 PDT
Comment on attachment 193105 [details] Fix compilation error Well spotted.
Alberto Garcia
Comment 16 2013-03-14 09:59:50 PDT
Do we need to reopen this bug in order to commit the patch?
Rob Buis
Comment 17 2013-03-15 09:40:00 PDT
(In reply to comment #16) > Do we need to reopen this bug in order to commit the patch? Let's try without.
Alberto Garcia
Comment 18 2013-03-18 10:50:49 PDT
(In reply to comment #17) > (In reply to comment #16) > > Do we need to reopen this bug in order to commit the patch? > > Let's try without. It didn't seem to work :)
Mike Fenton
Comment 19 2013-03-18 11:15:44 PDT
Re-opening to land patch.
WebKit Review Bot
Comment 20 2013-03-18 11:35:54 PDT
Comment on attachment 193105 [details] Fix compilation error Clearing flags on attachment: 193105 Committed r146092: <http://trac.webkit.org/changeset/146092>
WebKit Review Bot
Comment 21 2013-03-18 11:35:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.