Bug 111719

Summary: Web Inspector: Flame Chart. Draw items according to the timeline.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED INVALID    
Severity: Normal CC: apavlov, buildbot, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Ilya Tikhonovsky
Reported 2013-03-07 05:58:53 PST
The items in the CPUProfile are sorted by time of first invocation. The paint function receives them from latest to earliest but paints them from left to right. This will confuse the developers. So we need to change the painting position. We could change the visiting order but the algorithm would require more memory or would produce more garbage in that case. So I prefer to change the paint procedure.
Attachments
Patch (5.71 KB, patch)
2013-03-07 06:03 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (6.03 KB, patch)
2013-03-11 00:27 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2013-03-07 06:03:45 PST
Created attachment 191983 [details] Patch
Yury Semikhatsky
Comment 2 2013-03-10 23:18:26 PDT
(In reply to comment #0) > We could change the visiting order but the algorithm would require more memory or would produce more garbage in that case. > So I prefer to change the paint procedure. Why would it require more memory? Isn't it enough to simply change the order in which we push node's children on the stack?
Yury Semikhatsky
Comment 3 2013-03-10 23:23:03 PDT
Comment on attachment 191983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191983&action=review > Source/WebCore/inspector/front-end/FlameChart.js:205 > + height: this._yScaleFactor, Please rename _yScaleFactor to _barHeight
Ilya Tikhonovsky
Comment 4 2013-03-11 00:27:45 PDT
Created attachment 192414 [details] Patch
Ilya Tikhonovsky
Comment 5 2013-03-11 00:28:06 PDT
(In reply to comment #3) > (From update of attachment 191983 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191983&action=review > > > Source/WebCore/inspector/front-end/FlameChart.js:205 > > + height: this._yScaleFactor, > > Please rename _yScaleFactor to _barHeight done
Build Bot
Comment 6 2013-03-11 07:51:52 PDT
Comment on attachment 192414 [details] Patch Attachment 192414 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17024268 New failing tests: fast/css/sticky/inline-sticky.html
Ilya Tikhonovsky
Comment 7 2013-03-14 00:13:31 PDT
obsolete
Note You need to log in before you can comment on or make changes to this bug.