Bug 111717

Summary: Web Inspector: [CodeMirror] set indentation size according to devtools settings
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Andrey Lushnikov 2013-03-07 05:58:06 PST 
Set indentation size in CodeMirror experiment according to devtools settings.
Comment 1 Andrey Lushnikov 2013-03-07 06:00:48 PST 
Created attachment 191982 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-03-07 08:09:57 PST 
Comment on attachment 191982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191982&action=review

> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:59
> +    if (indent === WebInspector.TextUtils.Indent.TabCharacter) {

WebInspector.TextUtils.Indent is undefined
Comment 3 Andrey Lushnikov 2013-03-07 09:49:33 PST 
Comment on attachment 191982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191982&action=review

>> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:59
>> +    if (indent === WebInspector.TextUtils.Indent.TabCharacter) {
> 
> WebInspector.TextUtils.Indent is undefined

It was introduced here: https://bugs.webkit.org/show_bug.cgi?id=111715
Comment 4 WebKit Review Bot 2013-03-11 08:51:42 PDT 
Comment on attachment 191982 [details]
Patch

Clearing flags on attachment: 191982

Committed r145368: <http://trac.webkit.org/changeset/145368>
Comment 5 WebKit Review Bot 2013-03-11 08:51:45 PDT 
All reviewed patches have been landed.  Closing bug.