Bug 111698

Summary: Web Inspector: Change profile start button caption depending on profile type
Product: WebKit Reporter: Alexei Filippov <alph>
Component: Web Inspector (Deprecated)Assignee: Alexei Filippov <alph>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexei Filippov
Reported 2013-03-07 01:44:18 PST
For CPU like profile types the current "Start/Stop" buttons is ok. While for heap snapshot like profiles that do not start a continuous action change the button caption to "Snapshot".
Attachments
Patch (6.70 KB, patch)
2013-03-07 01:48 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (7.52 KB, patch)
2013-03-07 04:04 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (7.61 KB, patch)
2013-03-07 06:06 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexei Filippov
Comment 1 2013-03-07 01:48:20 PST
Created attachment 191950 [details] Patch
Alexei Filippov
Comment 2 2013-03-07 04:04:44 PST
Created attachment 191965 [details] Patch
Yury Semikhatsky
Comment 3 2013-03-07 05:05:47 PST
Comment on attachment 191965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191965&action=review > Source/WebCore/inspector/front-end/ProfileLauncherView.js:75 > + this._controlButton.textContent = WebInspector.UIString("Snapshot"); Take Snapshot or Capture?
Alexei Filippov
Comment 4 2013-03-07 06:06:43 PST
Created attachment 191984 [details] Patch
Alexei Filippov
Comment 5 2013-03-07 06:08:16 PST
Comment on attachment 191965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191965&action=review >> Source/WebCore/inspector/front-end/ProfileLauncherView.js:75 >> + this._controlButton.textContent = WebInspector.UIString("Snapshot"); > > Take Snapshot or Capture? Ok, let's go for "Take Snapshot" for now.
WebKit Review Bot
Comment 6 2013-03-07 07:30:41 PST
Comment on attachment 191984 [details] Patch Clearing flags on attachment: 191984 Committed r145074: <http://trac.webkit.org/changeset/145074>
WebKit Review Bot
Comment 7 2013-03-07 07:30:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.