Bug 111697

Summary:

Web Inspector: Flame Chart. Stick item color to the function.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	yurys: review+

Ilya Tikhonovsky

Reported 2013-03-07 01:32:04 PST

EOM

Attachments
Patch (5.19 KB, patch) 2013-03-07 01:47 PST, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Patch (5.08 KB, patch) 2013-03-07 04:36 PST, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2013-03-07 01:47:15 PST

Yury Semikhatsky

Comment 2 2013-03-07 04:25:06 PST

Comment on attachment 191949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191949&action=review > Source/WebCore/inspector/front-end/FlameChart.js:181 > + var lightness = this._highlightedNode === node ? 33 : 67; The color isn't restored when selected node changes. r- for this

Ilya Tikhonovsky

Comment 3 2013-03-07 04:36:16 PST

Ilya Tikhonovsky

Comment 4 2013-03-07 05:30:52 PST

(In reply to comment #2) > (From update of attachment 191949 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191949&action=review > > > Source/WebCore/inspector/front-end/FlameChart.js:181 > > + var lightness = this._highlightedNode === node ? 33 : 67; > > The color isn't restored when selected node changes. r- for this fixed

Ilya Tikhonovsky

Comment 5 2013-03-07 05:38:54 PST

Note You need to log in before you can comment on or make changes to this bug.