Bug 111697

Summary: Web Inspector: Flame Chart. Stick item color to the function.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Description Ilya Tikhonovsky 2013-03-07 01:32:04 PST 
EOM
Comment 1 Ilya Tikhonovsky 2013-03-07 01:47:15 PST 
Created attachment 191949 [details]
Patch
Comment 2 Yury Semikhatsky 2013-03-07 04:25:06 PST 
Comment on attachment 191949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191949&action=review

> Source/WebCore/inspector/front-end/FlameChart.js:181
> +            var lightness = this._highlightedNode === node ? 33 : 67;

The color isn't restored when selected node changes. r- for this
Comment 3 Ilya Tikhonovsky 2013-03-07 04:36:16 PST 
Created attachment 191970 [details]
Patch
Comment 4 Ilya Tikhonovsky 2013-03-07 05:30:52 PST 
(In reply to comment #2)
> (From update of attachment 191949 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191949&action=review
> 
> > Source/WebCore/inspector/front-end/FlameChart.js:181
> > +            var lightness = this._highlightedNode === node ? 33 : 67;
> 
> The color isn't restored when selected node changes. r- for this

fixed
Comment 5 Ilya Tikhonovsky 2013-03-07 05:38:54 PST 
Committed r145065: <http://trac.webkit.org/changeset/145065>