Summary: | Custom Elements: should support non-HTML namespaces. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
Component: | DOM | Assignee: | Web Components Team <webcomponents-bugzilla> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ericbidelman, esprehn+autocc, haraken, japhet, ojan.autocc, webcomponents-bugzilla, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 99688 | ||||||||
Attachments: |
|
Description
Hajime Morrita
2013-03-07 00:23:36 PST
Created attachment 195224 [details]
Patch
Comment on attachment 195224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195224&action=review > Source/WebCore/bindings/v8/CustomElementHelpers.h:59 > + static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*, AtomicString* namespaceURI = 0); Can we not pass by ref here? The ptr thing looks a bit weird. Created attachment 195456 [details]
Patch
(In reply to comment #2) > > Source/WebCore/bindings/v8/CustomElementHelpers.h:59 > > + static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*, AtomicString* namespaceURI = 0); > > Can we not pass by ref here? The ptr thing looks a bit weird. Right, fixed. Comment on attachment 195456 [details] Patch Clearing flags on attachment: 195456 Committed r147113: <http://trac.webkit.org/changeset/147113> All reviewed patches have been landed. Closing bug. |