Bug 111693 - Custom Elements: should support non-HTML namespaces.
Summary: Custom Elements: should support non-HTML namespaces.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Web Components Team
URL:
Keywords:
Depends on:
Blocks: 99688
  Show dependency tree / graph
 
Reported: 2013-03-07 00:23 PST by Hajime Morrita
Modified: 2013-03-28 07:32 PDT (History)
8 users (show)

See Also:

Attachments
Patch (18.34 KB, patch)
2013-03-26 22:24 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (18.62 KB, patch)
2013-03-27 19:00 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2013-03-07 00:23:36 PST 
Currently it only supports SVG. It should also support non-HTML namespaces like SVG.
Comment 1 Hajime Morrita 2013-03-26 22:24:57 PDT 
Created attachment 195224 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2013-03-27 09:28:48 PDT 
Comment on attachment 195224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195224&action=review

> Source/WebCore/bindings/v8/CustomElementHelpers.h:59
> +    static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*, AtomicString* namespaceURI = 0);

Can we not pass by ref here? The ptr thing looks a bit weird.
Comment 3 Hajime Morrita 2013-03-27 19:00:15 PDT 
Created attachment 195456 [details]
Patch
Comment 4 Hajime Morrita 2013-03-27 19:05:01 PDT 
(In reply to comment #2)
> > Source/WebCore/bindings/v8/CustomElementHelpers.h:59
> > +    static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*, AtomicString* namespaceURI = 0);
> 
> Can we not pass by ref here? The ptr thing looks a bit weird.

Right, fixed.
Comment 5 WebKit Review Bot 2013-03-28 07:32:36 PDT 
Comment on attachment 195456 [details]
Patch

Clearing flags on attachment: 195456

Committed r147113: <http://trac.webkit.org/changeset/147113>
Comment 6 WebKit Review Bot 2013-03-28 07:32:40 PDT 
All reviewed patches have been landed.  Closing bug.