Bug 111674

Summary: ConvertThis should be turned into Identity based on predictions in Fixup, rather than based on proofs in ConstantFolding
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
oliver: review+
patch for landing none

Description Filip Pizlo 2013-03-06 20:34:21 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-03-06 21:14:59 PST 
Created attachment 191911 [details]
the patch
Comment 2 Filip Pizlo 2013-03-06 21:18:04 PST 
*** Bug 110395 has been marked as a duplicate of this bug. ***
Comment 3 Oliver Hunt 2013-03-06 21:42:17 PST 
Comment on attachment 191911 [details]
the patch

Can you add some test cases to ensure we get the correct conversion behaviour?

Reviewed from my iPhone
Comment 4 Filip Pizlo 2013-03-06 21:44:45 PST 
(In reply to comment #3)
> (From update of attachment 191911 [details])
> Can you add some test cases to ensure we get the correct conversion behaviour?
> 
> Reviewed from my iPhone

I think LayoutTests/fast/js/dfg-convert-this-dom-window has good coverage for this already.

I'll try to add OSR exit test cases though.
Comment 5 Filip Pizlo 2013-03-06 23:54:46 PST 
Created attachment 191935 [details]
patch for landing
Comment 6 Filip Pizlo 2013-03-07 01:07:36 PST 
Landed in http://trac.webkit.org/changeset/145052