Bug 111666

Summary: Compute WebGL context attributes from DrawingBuffer when it is used
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: bajones, dino, esprehn+autocc, gman, jamesr, jbauman, ojan.autocc, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2013-03-06 19:18:07 PST
On ports where WebGLRenderingContext's back buffer is managed by the DrawingBuffer class (Source/WebCore/platform/graphics/gpu/DrawingBuffer.h), WebGLRenderingContext::getContextAttributes should be implemented in terms of the DrawingBuffer, not GraphicsContext3D. This mismatch is causing conformance test failures on platforms which don't support multisampling, probably among other problems.
Attachments
Patch (2.19 KB, patch)
2013-03-07 12:58 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2013-03-07 12:56:55 PST
After further examination, the DrawingBuffer determines all of its context creation attributes from the GraphicsContext3D. The only flag it determines itself is whether it can support multisampling based on the presence of the framebuffer_blit and framebuffer_multisample extensions. Fixing just the computation of the antialias flag.
Kenneth Russell
Comment 2 2013-03-07 12:58:56 PST
Created attachment 192071 [details] Patch
WebKit Review Bot
Comment 3 2013-03-07 17:08:53 PST
Comment on attachment 192071 [details] Patch Clearing flags on attachment: 192071 Committed r145159: <http://trac.webkit.org/changeset/145159>
WebKit Review Bot
Comment 4 2013-03-07 17:08:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.