Summary: | [ARM] isVFPPresent failed to detect vfp3 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | linzj <manjian2006> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | UNCONFIRMED --- | ||||||||||
Severity: | Critical | CC: | buildbot, clopez, commit-queue, keith_miller, mark.lam, msaboff, ngockhanhlam87, ossy, saam | ||||||||
Priority: | P1 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Android | ||||||||||
OS: | Android | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 108645 | ||||||||||
Attachments: |
|
Description
linzj
2013-03-06 18:46:20 PST
you don't want me to submit a patch,because I can't checkout the whole svn trunk.I am in China,where is "protected" by the Great Fire Wall. well,seems a patch is mandatory here Created attachment 194165 [details]
change to vfp3
Created attachment 194166 [details]
patch
Created attachment 194167 [details]
patch
Comment on attachment 194167 [details] patch Rejecting attachment 194167 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 194167, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit ed46a0b..9cd447a master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 158402 = ed46a0b8b39c279bd312a1751a6d47cd897fafb8 r158404 = 9cd447a9654a49da4bb567a48886a88e9c6a144b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/19498010 Hey. This patch has been sitting here for 2 years, with an r+ and just with a cq- because it don't has a changelog. The patch still applies, should we commit it? It only needs a changelog. (In reply to comment #7) > Hey. This patch has been sitting here for 2 years, with an r+ and just with > a cq- because it don't has a changelog. > > The patch still applies, should we commit it? It only needs a changelog. I agree, let's add a changelog and commit it. |