Bug 111657

Summary: Don't give PageAllocationAligned the option to allocate executable memory
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, jchaffraix, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Oliver Hunt 2013-03-06 18:11:38 PST
Don't give PageAllocationAligned the option to allocate executable memory
Comment 1 Oliver Hunt 2013-03-06 18:12:06 PST
Created attachment 191881 [details]
Patch
Comment 2 Geoffrey Garen 2013-03-06 18:14:46 PST
Comment on attachment 191881 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2013-03-06 18:15:49 PST
Attachment 191881 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/PageAllocationAligned.cpp', u'Source/WTF/wtf/PageAllocationAligned.h']" exit_code: 1
Source/WTF/wtf/PageAllocationAligned.h:44:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WTF/wtf/PageAllocationAligned.h:44:  The parameter name "usage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Oliver Hunt 2013-03-06 18:16:34 PST
Committed r145018: <http://trac.webkit.org/changeset/145018>
Comment 5 Julien Chaffraix 2013-03-06 18:57:02 PST
This change broke all the builds (because non Mac platforms used the boolean) but you never saw that because you didn't run the EWS. There is a patch to fix it in bug 111659.

But it also broke Apple Win on top of it as the WTF exported symbol changed.

Unless you fix this within 30 minutes, I will have to roll this change out.
Comment 6 Julien Chaffraix 2013-03-06 19:00:23 PST
> But it also broke Apple Win on top of it as the WTF exported symbol changed.
> 
> Unless you fix this within 30 minutes, I will have to roll this change out.

Actually scratch that, Ryosuke corrected me. It will be corrected by bug 111659. Thanks for wasting everybody's time.
Comment 7 Oliver Hunt 2013-03-06 20:04:15 PST
(In reply to comment #6)
> > But it also broke Apple Win on top of it as the WTF exported symbol changed.
> > 
> > Unless you fix this within 30 minutes, I will have to roll this change out.
> 
> Actually scratch that, Ryosuke corrected me. It will be corrected by bug 111659. Thanks for wasting everybody's time.

That's the one of least professional comments i've seen yet.  Obviously I did not deliberately break other builds (i thought i had removed the use of the executable parameter for other builds).