Bug 111630

Summary: [texmap] Remove direct access to clip state from clip stack
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: Layout and RenderingAssignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, igor.oliveira, kalyan.kondapally, luiz, noam, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 111566    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Bruno Abinader (history only)
Reported 2013-03-06 14:49:32 PST
As we are now monitoring the clip state from TextureMapperGL/BitmapTextureGL, have direct access to clip state object would eventually make it dirty without properly setting the 'clipStateDirty' flag. This bug intends to substitute direct access with auxiliary functions which would set the clip state dirty when necessary.
Attachments
Patch (5.25 KB, patch)
2013-03-06 14:54 PST, Bruno Abinader (history only) 		no flags
DetailsFormatted DiffDiff
Patch (5.36 KB, patch)
2013-03-07 06:54 PST, Bruno Abinader (history only) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bruno Abinader (history only)
Comment 1 2013-03-06 14:54:09 PST
Created attachment 191836 [details] Patch Proposed patch
Bruno Abinader (history only)
Comment 2 2013-03-07 06:54:57 PST
Created attachment 191988 [details] Patch Rebased patch after changes from r145071
Allan Sandfeld Jensen
Comment 3 2013-03-07 07:04:13 PST
Comment on attachment 191988 [details] Patch LGTM
WebKit Review Bot
Comment 4 2013-03-07 07:27:58 PST
Comment on attachment 191988 [details] Patch Clearing flags on attachment: 191988 Committed r145073: <http://trac.webkit.org/changeset/145073>
WebKit Review Bot
Comment 5 2013-03-07 07:28:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.