Bug 111630

Summary: [texmap] Remove direct access to clip state from clip stack
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: Layout and RenderingAssignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, igor.oliveira, kalyan.kondapally, luiz, noam, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 111566    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Bruno Abinader (history only) 2013-03-06 14:49:32 PST 
As we are now monitoring the clip state from TextureMapperGL/BitmapTextureGL, have direct access to clip state object would eventually make it dirty without properly setting the 'clipStateDirty' flag. This bug intends to substitute direct access with auxiliary functions which would set the clip state dirty when necessary.
Comment 1 Bruno Abinader (history only) 2013-03-06 14:54:09 PST 
Created attachment 191836 [details]
Patch

Proposed patch
Comment 2 Bruno Abinader (history only) 2013-03-07 06:54:57 PST 
Created attachment 191988 [details]
Patch

Rebased patch after changes from r145071
Comment 3 Allan Sandfeld Jensen 2013-03-07 07:04:13 PST 
Comment on attachment 191988 [details]
Patch

LGTM
Comment 4 WebKit Review Bot 2013-03-07 07:27:58 PST 
Comment on attachment 191988 [details]
Patch

Clearing flags on attachment: 191988

Committed r145073: <http://trac.webkit.org/changeset/145073>
Comment 5 WebKit Review Bot 2013-03-07 07:28:02 PST 
All reviewed patches have been landed.  Closing bug.