Bug 111628

Summary: [nrwt] handle corrupt http server pid files cleanly
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, kinuko, ojan, tony, webkit.review.bot
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2013-03-06 14:41:29 PST
[nrwt] handle corrupt http server pid files cleanly
Attachments
Patch (8.24 KB, patch)
2013-03-06 14:42 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2013-03-06 14:42:52 PST
Created attachment 191835 [details] Patch
Dirk Pranke
Comment 2 2013-03-06 14:44:07 PST
Comment on attachment 191835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191835&action=review > Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py:109 > + self._pid = actual_pid It's unfortunate this block is almost completely duplicated between here and the above code, but there's no good way to share the logic as we need to ensure that the whole stop block is wrapped in the finally that deletes the file.
Dirk Pranke
Comment 3 2013-03-06 14:44:33 PST
See https://code.google.com/p/chromium/issues/detail?id=177798 for the motivating problem.
Eric Seidel (no email)
Comment 4 2013-03-06 19:38:11 PST
Comment on attachment 191835 [details] Patch Looks reasonable. Thank you.
WebKit Review Bot
Comment 5 2013-03-07 13:01:01 PST
Comment on attachment 191835 [details] Patch Clearing flags on attachment: 191835 Committed r145122: <http://trac.webkit.org/changeset/145122>
WebKit Review Bot
Comment 6 2013-03-07 13:01:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.