| Summary: | [GTK][WK2] Add webkit_uri_request_set_uri to WebKit2 GTK+ API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | cgarcia, gustavo, gyuyoung.kim, mrobinson, rakuco, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Manuel Rego Casasnovas
2013-03-06 13:43:23 PST
Created attachment 191825 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 191825 [details] Patch Thanks for the patch, but this has already been added, see patch in bug #83681, it hasn't landed in trunk yet because it's waiting for a WebKit2 owner, but landed in the stable branch already. In any case your patch has some issues, you are allowing the API to modify a construct only property, you should change the property to not be construct only, and use webkit_uri_request_set_uri()in the GObject setter too, emitting the notify signal when it changes. (In reply to comment #3) > (From update of attachment 191825 [details]) > Thanks for the patch, but this has already been added, see patch in bug #83681, it hasn't landed in trunk yet because it's waiting for a WebKit2 owner, but landed in the stable branch already. In any case your patch has some issues, you are allowing the API to modify a construct only property, you should change the property to not be construct only, and use webkit_uri_request_set_uri()in the GObject setter too, emitting the notify signal when it changes. Ok, sorry for the noise then. Closing as duplicated. *** This bug has been marked as a duplicate of bug 83681 *** |