Bug 111601
| Summary: | webkit-patch apply-attachment fails to delete some files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, alancutter, dbates, dpranke, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Reproduction steps:
1. Sync to r144944 or any other revision before the patch on https://bugs.webkit.org/show_bug.cgi?id=111491 is landed.
2. webkit-patch apply-attachment 191591 [details]
Expected results:
All files deleted in the patch are also deleted
Actual results:
The following files are not deleted:
LayoutTests/platform/chromium-mac-lion/editing/pasteboard/paste-table-cells-expected.png
LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png
LayoutTests/platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png
LayoutTests/platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png
LayoutTests/platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt
LayoutTests/platform/gtk/editing/pasteboard/paste-table-cells-expected.txt
LayoutTests/platform/mac/editing/pasteboard/paste-table-cells-expected.txt
LayoutTests/platform/qt/editing/pasteboard/paste-table-cells-expected.txt
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I believe this just uses svn-apply under the covers.
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py#L152
Daniel Bates
Will look into this issue shortly.