| Summary: | SVG pattern to pattern reference does not work if first pattern has a child node | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||
| Component: | SVG | Assignee: | Florin Malita <fmalita> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | d-r, fmalita, pdr, schenney, webkit.review.bot, zimmermann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 191766 [details]
Patch
Comment on attachment 191766 [details]
Patch
This change is very reasonable.
Do you mind checking that the ~20 other instances of hasChildNodes() do not have the same problem?
(In reply to comment #2) > (From update of attachment 191766 [details]) > This change is very reasonable. > > Do you mind checking that the ~20 other instances of hasChildNodes() do not have the same problem? The remaining users look good. Comment on attachment 191766 [details] Patch Clearing flags on attachment: 191766 Committed r144948: <http://trac.webkit.org/changeset/144948> All reviewed patches have been landed. Closing bug. |
Created attachment 191759 [details] Not working pattern to pattern reference The following simple reference of another pattern does not work: <pattern xlink:href="#pattern2" id="pattern1"> </pattern> I assume this is because of the newline that creates a TextNode. With this node we do not reference the second pattern anymore. The following does work: <pattern xlink:href="#pattern2" id="pattern1"></pattern> Adobe Illustrator exports the first example, why often patterns don't work exported from Illustrator.